Fix libc deprecations #1072
Merged
Fix libc deprecations #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
approved these changes
May 31, 2019
|
there seem to be more deprecations than showed up on my machine, travis has some failures.. i'll push an update soon-ish. |
|
bors r- |
Canceled |
|
Any update? We're still very interested in this PR. |
On musl, pthread_t is a pointer type.
libc just undefined MADV_SOFT_OFFLINE on mips. rust-lang/libc#1365 Fixes nix-rust#1074
libc just changed the signedness of sigaction.sa_flags for Android. rust-lang/libc@841b3eb
There were some breaking changes between 0.2.55 and 0.2.57. Now Nix will only work with the later version.
asomers
force-pushed
the
fix-libc-deprecations
branch
from
bce3e8c
to
59fabaf
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 3, 2019
1072: Fix libc deprecations r=asomers a=dario23 The `libc` crate now uses rust types in some places where previously types like `libc::uint8_t` had been defined. This PR adjusts nix's code to reflect these simplifications. Co-authored-by: Johannes Schilling <dario@deaktualisierung.org> Co-authored-by: Alan Somers <asomers@gmail.com>
Build succeeded
|
|
@asomers thanks for completing; wasn't available the last two days :-) |
asomers
added a commit
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
libccrate now uses rust types in some places where previously types likelibc::uint8_thad been defined. This PR adjusts nix's code to reflect these simplifications.