Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket: expose MSG_WAITALL in MsgFlags #1079

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

stefano-garzarella
Copy link
Contributor

MSG_WAITALL can be useful with recv() to wait the full amount of data requested.

@asomers
Copy link
Member

asomers commented Jun 4, 2019

This needs a CHANGELOG entry. Otherwise it looks good.

@stefano-garzarella
Copy link
Contributor Author

This needs a CHANGELOG entry. Otherwise it looks good.

Thanks, I just added the entry in the CHANGELOG.

@stefano-garzarella
Copy link
Contributor Author

@asomers I updated my commit adding the entry in the CHANGELOG and I did a force-pushed to use this PR. Let me know if it is okay.

@asomers
Copy link
Member

asomers commented Jun 7, 2019

I'm sorry, but you'll need to rebase. I made a release yesterday so your CHANGELOG entry isn't going to merge correctly.

MSG_WAITALL can be useful with recv() to wait the full amount of data
requested.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
@stefano-garzarella
Copy link
Contributor Author

@asomers don't worry :), I rebased and force-pushed.

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jun 7, 2019
1079: socket: expose MSG_WAITALL in MsgFlags r=asomers a=stefano-garzarella

MSG_WAITALL can be useful with recv() to wait the full amount of data requested.

Co-authored-by: Stefano Garzarella <sgarzare@redhat.com>
@bors
Copy link
Contributor

bors bot commented Jun 7, 2019

Build succeeded

@bors bors bot merged commit 3ffbd40 into nix-rust:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants