Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings on Rust 1.37.0 #1095

Merged
merged 3 commits into from
Jul 13, 2019
Merged

Fix warnings on Rust 1.37.0 #1095

merged 3 commits into from
Jul 13, 2019

Commits on Jul 13, 2019

  1. Fix warnings on Rust 1.37.0 

    * Replace obsolete range syntax "..." with inclusive range "..="
* Use dyn Trait syntax instead of Box<Trait>
* Raise MSRV to 1.27.0 (for dyn Trait syntax)
* Raise MSRV to 1.31.0 (because of rand)

tempfile pulls in rand, and rand pulls in fuchsia-cprng, which requires
1.31.0.  Why rand pulls in fuchsia-cprng I don't know.  It's specified
as a target-specific dependency, but Cargo tries to build it anyway
(only on Linux, not on FreeBSD or OSX).  A bug in Cargo 1.27.0?
    @asomers
    asomers committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    c156af5 View commit details
    Browse the repository at this point in the history

  2. Do "cargo check" instead of "cargo build" for the MSRV check 

    check is faster than build.
    @asomers
    asomers committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    43df789 View commit details
    Browse the repository at this point in the history

  3. Temporarily allow deprecated items 

    This fixes the tests on Rust 1.38.0.  We'll fix them for real after
release 0.15.0.

Issue nix-rust#1096
    @asomers
    asomers committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    2373ac8 View commit details
    Browse the repository at this point in the history