Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise minimum supported Rust version to 1.36.0 #1108

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Raise minimum supported Rust version to 1.36.0 #1108

merged 2 commits into from
Aug 29, 2019

Conversation

otavio
Copy link
Contributor

@otavio otavio commented Aug 22, 2019

Signed-off-by: Otavio Salvador otavio@ossystems.com.br

asomers
asomers requested changes Aug 22, 2019
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you please note in the commit message why you're raising MSRV (for mem::MaybeUninit). Also, don't forget to update the MSRV in README.md.

@otavio
Raise minimum supported Rust version to 1.36.0
11f5e0d 
The minimum supported Rust version is being raised to 1.36.0 as this
is the first release to support the `mem::MaybeUninit` feature.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
@otavio
Copy link
Contributor Author

otavio commented Aug 28, 2019

@asomers I rebased this on top of current master; please take a look.

@asomers
Copy link
Member

asomers commented Aug 28, 2019

Please note in the commit message the reason for raising the msrv. Otherwise, it looks good.

@otavio
Copy link
Contributor Author

otavio commented Aug 28, 2019

It is, on the long description.

@asomers
Copy link
Member

asomers commented Aug 28, 2019

Ahh, my apologies. I didn't see it on my tiny cell phone screen. I'll take a look at the musl failure.

@asomers
Fix some ioctl tests on musl
a9dd7ce 
Weirdly, musl uses i32 to store the ioctl opcode
asomers
asomers approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Aug 29, 2019
@bors @otavio @asomers
Merge #1108
faaacf9 
1108: Raise minimum supported Rust version to 1.36.0 r=asomers a=otavio

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Co-authored-by: Otavio Salvador <otavio@ossystems.com.br>
Co-authored-by: Alan Somers <asomers@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 29, 2019

Build succeeded

@bors bors bot merged commit a9dd7ce into nix-rust:master Aug 29, 2019
@otavio otavio deleted the raise-rust-to-1_36 branch September 5, 2019 01:36
@atouchet atouchet mentioned this pull request Sep 21, 2019
Merged
bors bot added a commit that referenced this pull request Sep 21, 2019
@bors @atouchet
Merge #1126
ac5de6b 
1126: Relax some dependency versions r=asomers a=atouchet

The minimum supported Rust version was bumped in #1108 so these restrictions are no longer necessary.

Co-authored-by: Alex Touchet <alextouchet@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@otavio @asomers