Derive Ord, PartialOrd for Pid
#1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posborne
approved these changes
Mar 2, 2020
|
Bah, bors r+ |
|
@posborne, would you like me to add a changelog entry with this PR, or do maintainers prefer to do that separately post-merge? |
|
@ranweiler Yes, good call. We do prefer them to be a part of the PR. Looks like things didn't go through before so go ahead and add now. |
|
@posborne added! |
|
Thanks @ranweiler, looks good. Can you squash down to a single commit and then I'll kick off the merge. |
|
@posborne done. |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1188.