Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sys::socket::addr::from_libc_sockaddr from the public API #1215

Merged
merged 1 commit into from
May 1, 2020
Merged

Remove sys::socket::addr::from_libc_sockaddr from the public API #1215

merged 1 commit into from
May 1, 2020

Conversation

asomers
Copy link
Member

@asomers asomers commented Apr 12, 2020

This function never should've been public, since it's basically
impossible to use directly. It's only public due to an oversight from
PR #667 .

@asomers
Remove sys::socket::addr::from_libc_sockaddr from the public API
494d4f7 
This function never should've been public, since it's basically
impossible to use directly.  It's only public due to an oversight from
PR nix-rust#667 .
@asomers
Copy link
Member Author

asomers commented Apr 12, 2020

CC @mwanner . This is basically cleanup from PR #667 .

posborne
posborne approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@posborne posborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented May 1, 2020

Build succeeded:

@bors bors bot merged commit 609d429 into nix-rust:master May 1, 2020
@coolreader18
Copy link
Contributor

This would actually be really useful to me; it's not impossible to use directly if you're doing FFI and get a *const sockaddr.

@asomers asomers deleted the from_libc_sockaddr branch June 4, 2021 03:02
@asomers
Copy link
Member Author

asomers commented Jun 4, 2021

This would actually be really useful to me; it's not impossible to use directly if you're doing FFI and get a *const sockaddr.

What is your use case? How are you getting the *const sockaddr?

@coolreader18
Copy link
Contributor

Well I suppose I actually have a socket2::SockAddr, so at the low level it's from something like getsockname or getpeername or recvfrom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posborne posborne posborne approved these changes

@Susurrus Susurrus Awaiting requested review from Susurrus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asomers @coolreader18 @posborne