Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace void crate with Rust standard lib Infallible type #1239

Merged
merged 1 commit into from
May 17, 2020

Conversation

oherrala
Copy link
Contributor

std::convert::Infallible has been available since Rust 1.34 and nix currently targets Rust 1.36 or later so this should not cause problems.

Fixes #1238

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this change looks good. But could you please add a link to the PR in the CHANGELOG section?

std::convert::Infallible has been available since Rust 1.34 and nix
currently targets Rust 1.36 or later so this should not cause
problems.

Fixes nix-rust#1238
@oherrala
Copy link
Contributor Author

@asomers Changelog fixed. Thanks!

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors bors bot merged commit d3fef37 into nix-rust:master May 17, 2020
@bors
Copy link
Contributor

bors bot commented May 17, 2020

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace void's Void with std Infallible
2 participants