-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clippy cleanup #1244
Merged
Merged
Clippy cleanup #1244
Commits on Jun 27, 2020
-
Fix an unaligned pointer read in Inotify::read_events
Reported-by: Clippy
Configuration menu - View commit details
-
Copy full SHA for f4fc06d - Browse repository at this point
Copy the full SHA f4fc06dView commit details -
Make sys::socket::sockaddr_storage a safe function
It already fully validated its arguments, so there's no need for it to be `unsafe`.
Configuration menu - View commit details
-
Copy full SHA for d6f0471 - Browse repository at this point
Copy the full SHA d6f0471View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f68bfd - Browse repository at this point
Copy the full SHA 6f68bfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 729e782 - Browse repository at this point
Copy the full SHA 729e782View commit details -
Prefer to pass Inotify by value instead of by reference
It's small and `Copy`, so pass by value is more efficient. This is technically a breaking change, but most code should compile without changes.
Configuration menu - View commit details
-
Copy full SHA for e6e25ec - Browse repository at this point
Copy the full SHA e6e25ecView commit details -
All it does is assign a value to a thread-local int. There's nothing unsafe about that.
Configuration menu - View commit details
-
Copy full SHA for 3094772 - Browse repository at this point
Copy the full SHA 3094772View commit details -
Make SockAddr::as_ffi_pair safe
It was only marked unsafe because it did a pointer cast, but that particular pointer cast is always allowed by C.
Configuration menu - View commit details
-
Copy full SHA for af45859 - Browse repository at this point
Copy the full SHA af45859View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46a8698 - Browse repository at this point
Copy the full SHA 46a8698View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27d39b2 - Browse repository at this point
Copy the full SHA 27d39b2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.