Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix num_microseconds impl for TimeSpec #1322

Closed
wants to merge 1 commit into from
Closed

Fix num_microseconds impl for TimeSpec #1322

wants to merge 1 commit into from

Conversation

birkenfeld
Copy link

No description provided.

asomers
asomers requested changes Oct 22, 2020
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG entry, please.

@birkenfeld
Copy link
Author

Done.

asomers
asomers approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Oct 22, 2020
@bors @birkenfeld
Merge #1322
2b0ddea 
1322: Fix `num_microseconds` impl for `TimeSpec` r=asomers a=birkenfeld



Co-authored-by: Georg Brandl <georg@python.org>
@bors
Copy link
Contributor

bors bot commented Oct 22, 2020

Timed out.

@kamalmarhubi
Copy link
Member

bors r+

retrying

bors bot added a commit that referenced this pull request Nov 11, 2020
@bors @birkenfeld
Merge #1322
ac1745c 
1322: Fix `num_microseconds` impl for `TimeSpec` r=kamalmarhubi a=birkenfeld



Co-authored-by: Georg Brandl <georg@python.org>
@bors
Copy link
Contributor

bors bot commented Nov 11, 2020

Timed out.

@asomers
Copy link
Member

asomers commented Nov 23, 2023

Superseded by #1801

@asomers asomers closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@birkenfeld @kamalmarhubi @asomers