unistd: Increase maximum passwd/group buffer to 1MB #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to add a changelog entry if this needs one. Also, the way this code currently works is that if the platform supports |
asomers
requested changes
Mar 25, 2021
We have one UNIX group that contains most of our users whose size is about 20 kB, so `Group::from_name` is failing with ERANGE. The discussion on PR nix-rust#864 suggests that 1 MB is a reasonable maximum - it follows what FreeBSD's libc does. (glibc appears to have no maximum on the _r function and will just double the buffer until malloc fails, but that's not particularly Rusty.)
geofft
force-pushed
the
bigger-nss-buffer
branch
from
aeabd36
to
2b6f77a
Compare
geofft
added a commit
to twosigma/nsncd
that referenced
this pull request
Aug 15, 2021
This pulls in nix-rust/nix#1409 "unistd: Increase maximum passwd/group buffer to 1MB". The only breaking change that is relevant to us is that atoi now parses minus signs by default, but that (oddly) appears to match glibc nscd's behavior. There are also some MSRV bumps. Don't update nix to the very latest version to maintain MSRV <= 1.41 for compatibility with Debian Stretch (see #29); the other updates aree fine. Also run `cargo update` with 1.41, which removes the `version = 3` marker from Cargo.lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have one UNIX group that contains most of our users whose size is
about 20 kB, so
Group::from_nameis failing with ERANGE.The discussion on PR #864 suggests that 1 MB is a reasonable maximum -
it follows what FreeBSD's libc does. (glibc appears to have no maximum
on the _r function and will just double the buffer until malloc fails,
but that's not particularly Rusty.)