Add getresuid() and getresgid() to unistd #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Apr 23, 2021
jerylvaz
force-pushed
the
getresuid-getresgid
branch
5 times, most recently
from
3971a9b
to
43e074e
Compare
|
@asomers What should be done with the unrelated test failure? |
asomers
requested changes
May 1, 2021
jerylvaz
force-pushed
the
getresuid-getresgid
branch
from
43e074e
to
b86ffd5
Compare
asomers
reviewed
May 16, 2021
src/unistd.rs
Outdated
| /// - `Err(x)`: libc error code on failure. | ||
| /// | ||
| #[inline] | ||
| pub fn getresuid() -> Result<(Uid, Uid, Uid)> { |
There was a problem hiding this comment.
Returning a tuple is a very old fashioned and failure-prone technique. Better to return a structure. That way the meaning is obvious even without consulting the documentation. Something like:
struct ResUid {
real: Uid,
effective: Uid,
saved: uid
}
jerylvaz
force-pushed
the
getresuid-getresgid
branch
2 times, most recently
from
9450b0b
to
ae59760
Compare
|
Looks good, but you'll have to rebase to fix the CI failure on FreeBSD. |
jerylvaz
force-pushed
the
getresuid-getresgid
branch
from
ae59760
to
ef58b0a
Compare
asomers
requested changes
May 31, 2021
| @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file. | |||
| This project adheres to [Semantic Versioning](https://semver.org/). | |||
|
|
|||
| ## [Unreleased] - ReleaseDate | |||
| ### Added | |||
There was a problem hiding this comment.
Please fix the CHANGELOG. There was a merge error, and now there are two "Added" sections.
jerylvaz
force-pushed
the
getresuid-getresgid
branch
from
ef58b0a
to
b481a0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.