Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sendfile64 #1439

Merged
merged 3 commits into from
May 30, 2021
Merged

Add sendfile64 #1439

merged 3 commits into from
May 30, 2021

Conversation

tdryer
Copy link
Contributor

@tdryer tdryer commented May 28, 2021

sendfile64 is a Linux-specific call with a wider type for the offset argument than sendfile.

This is largely a copy of the existing sendfile function and associated test.

@tdryer
Add sendfile64
81c9e2d 
`sendfile64` is a Linux-specific call with a wider type for the `offset`
argument than `sendfile`.

This is largely a copy of the existing `sendfile` function and
associated test.
@tdryer
Disable sendfile64 on android
65ab8d7 
It's not available from libc on that platform.
@tdryer
Add pull request link to changelog
fb5d942
asomers
asomers approved these changes May 30, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors r+

bors bot added a commit that referenced this pull request May 30, 2021
@bors @tdryer
Merge #1439
509c0e8 
1439: Add sendfile64 r=asomers a=tdryer

`sendfile64` is a Linux-specific call with a wider type for the `offset` argument than `sendfile`.

This is largely a copy of the existing `sendfile` function and associated test.

Co-authored-by: Tom Dryer <tomdryer.com@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 30, 2021

Build failed:

@asomers
Copy link
Member

asomers commented May 30, 2021

bors retry

@bors
Copy link
Contributor

bors bot commented May 30, 2021

Build succeeded:

@bors bors bot merged commit df9ed93 into nix-rust:master May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tdryer @asomers