Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add epoll_pwait #1488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add epoll_pwait #1488

wants to merge 1 commit into from

Conversation

DBLouis
Copy link
Contributor

@DBLouis DBLouis commented Aug 10, 2021

No description provided.

@DBLouis
Copy link
Contributor Author

DBLouis commented Aug 11, 2021

It seems epoll_pwait is not available on Android

@DBLouis DBLouis force-pushed the epoll_pwait branch 2 times, most recently from 311d0da to 161c272 Compare August 11, 2021 05:31
@asomers
Copy link
Member

asomers commented Aug 18, 2021

@DBLouis can you fix the test failures?

@asomers
Copy link
Member

asomers commented Aug 18, 2021

You must rebase to fix the errors relating to bitflags.

@asomers
Copy link
Member

asomers commented Aug 18, 2021

Since you're in here, would you mind adding doc comments for the epoll stuff?

@SteveLauC
Copy link
Member

HI @DBLouis, if you are still interested in doing this, you should add a pwait() method to struct Epoll, we have changed its interface in #1882, and now those epoll_xxx() wrappers are deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DBLouis @asomers @SteveLauC