WIP implement some GETREGSET functionality for x64 and aarch64 #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwhite
reviewed
Oct 24, 2022
Comment on lines
+289
to
+291
| // If we get the struct definition wrong for a platform, linux can just scribble all over | ||
| // our memory. In some sense it's "too late" because it could have written past the bounds | ||
| // of our `data` value, but it's better to try to crash now than keep the program going! |
There was a problem hiding this comment.
I don't think this comment is accurate. From what I understand reading the ptrace docs, it won't write past the end of our buffer since it knows that from the input iov_len. It sets the length of iov_len so that we can know if our buffer is too small or too large for the full set of registers. So, there shouldn't be any stack corruption here as far as I can tell (but this assertion is still great to have).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CFGs are kinda all over the place... I don't have a good sense for how fragmented the different env's are.
Note that this depends on rust-lang/libc#2719 for the definitions of user_fpsimd_struct