Deprecate IpAddr, Ipv4Addr, and Ipv6Addr #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
force-pushed
the
deprecate_ipaddr
branch
2 times, most recently
from
e7c2321
to
5661f24
Compare
|
Ugh, apparently you can't deference a pointer in a const fn until rustc 1.57.0. Changing it to a mem::transmute only lowers the compatibility threshold to 1.56.0. |
rtzoeller
approved these changes
Mar 23, 2022
Because they're redundant with types in the standard library. Fixes nix-rust#1681
asomers
force-pushed
the
deprecate_ipaddr
branch
from
677c656
to
fbeabf3
Compare
|
bors r=rtzoeller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because they're redundant with types in the standard library.
Fixes #1681