Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: take AsFd by value #1932

Merged
merged 2 commits into from
Dec 9, 2022
Merged

refactor: take AsFd by value #1932

merged 2 commits into from
Dec 9, 2022

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Dec 9, 2022 •
edited

What this PR does

  1. Changes the fd type to take AsFd by value for the I/O safety PRs that are merged.

asomers
asomers approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that you barely had to touch the test files is a strong endorsement of this change.

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 9, 2022

Build succeeded:

@bors bors bot merged commit e11646e into nix-rust:master Dec 9, 2022
@SteveLauC SteveLauC deleted the take-AsFd-by-value branch December 10, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SteveLauC @asomers