Add suspend to sys::signal::SigSet
#1997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2023 12:48
This adds a simple wrapper for libc::sigsuspend. `sigsuspend` either doesn't return (if the sighandler terminates the process) or returns -1 and sets errno to EITR. So if this function returns, the return value must be -1 and does not need to be explicitly returned by `SigSet::suspend`.
VorpalBlade
reviewed
Feb 10, 2023
There was a problem hiding this comment.
I'm not affiliated with the nix project, so take this review with a grain of salt. I simply noticed that the project seems a bit overloaded and decided to help.
Overall this seems good. However:
- There are CI failures that needs to be fixed (obviously)
- Errno handling for non-Linux might need further investigation.
- The test feels a bit work in progress to be honest. So I won't really review it in it's current state. TODO comments etc needs to be dealt with.
| #[cfg(not(target_os = "redox"))] // Redox does not yet support sigsuspend | ||
| #[cfg_attr(docsrs, doc(cfg(all())))] | ||
| pub fn suspend(&self) { | ||
| unsafe { libc::sigsuspend(&self.sigset as *const libc::sigset_t) }; |
There was a problem hiding this comment.
According to the man page it is possible for this to return with EINTR or EFAULT on Linux. EINTR is the normal case for this. But should we handle EFAULT? It can't happen in this abstraction (and would need unsafe in general in Rust):
EFAULT mask points to memory which is not a valid part of the process address space.
But it also feels weird to ignore errors. And I don't have the access to other *nix systems to check if there are other fault conditions in those cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple wrapper for libc::sigsuspend.
sigsuspendeither doesn't return (if the sighandler terminates the process) or returns -1 and sets errno to EITR. So if this function returns, the return value must be -1 and does not need to be explicitly returned bySigSet::suspend.In issue #1994 I asked for hints. This is what I got.
I want to add a test, but have difficulties with kill and making sure the test never blocks.