Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vsock support for macOS #2056

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Jun 16, 2023

Adds vsock support for macOS. It's not possible to create a listening
vsock socket on a macOS host, but you can create one from inside a
VM and connect back to the host.

@tzneal tzneal force-pushed the add-vsock-support-for-macos branch 2 times, most recently from 268bec3 to 7b892bf Compare June 16, 2023 18:49
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a CHANGELOG. Also, I think there will be a merge conflict in Cargo.toml if you don't rebase.

@tzneal tzneal force-pushed the add-vsock-support-for-macos branch from f6017ee to 7a98262 Compare July 18, 2023 12:31
@tzneal
Copy link
Contributor Author

tzneal commented Jul 18, 2023

This needs a CHANGELOG. Also, I think there will be a merge conflict in Cargo.toml if you don't rebase.

Sounds good, thanks!

@asomers
Copy link
Member

asomers commented Aug 6, 2023

There was another CHANGELOG merge conflict, but I fixed that one.

bors r+

@bors bors bot merged commit 78a4d9e into nix-rust:master Aug 6, 2023
40 checks passed
@tzneal tzneal deleted the add-vsock-support-for-macos branch August 7, 2023 13:33
@tzneal
Copy link
Contributor Author

tzneal commented Aug 7, 2023

Thanks for fixing the changelog conflict!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants