Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax lifetime requirements for PollFd::new #2134

Merged
merged 4 commits into from
Oct 1, 2023
Merged

Relax lifetime requirements for PollFd::new #2134

merged 4 commits into from
Oct 1, 2023

Commits on Sep 30, 2023

  1. Relax lifetime requirements for PollFd::new 

    Fixes #2118
    @asomers
    asomers committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    8b82c46 View commit details
    Browse the repository at this point in the history

  2. Take BorrowedFd as the argument for PollFd::new 

    &AsFd didn't work because there are 'static types, like std::fs::File,
which implement AsFd.  The created BorrowedFd type within the
PollFd::new method would have a very brief lifetime, but the PhantomData
would capture the lifetime of the std::fs::File.  Taking BorrowFd<'fd>
argument makes the lifetime explicit.
    @asomers
    asomers committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    c9c7d91 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2023

  1. fix legacy comment

    @SteveLauC
    SteveLauC committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    3e197e5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pollfd-lifetime

    @SteveLauC
    SteveLauC committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    3925fcb View commit details
    Browse the repository at this point in the history