Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: put test_prctl and test_clearenv under test.rs #2212

Closed
wants to merge 2 commits into from

Conversation

SteveLauC
Copy link
Member

What does this PR do

Move test_prctl and test_clearenv to test.rs

I actually have no idea why they are put under their own sections, but it seems to be ok to let them live with other tests.

No actual code changes in test/sys/test_prctl.rs, I just removed

#[cfg(target_os = "linux")]
#[cfg(feature = "process")]
mod test_prctl {
}

and shifted the code

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@asomers
Copy link
Member

asomers commented Nov 26, 2023

The prctl stuff is in its own test program because it changes process-wide settings that might affect other tests.
#1550 (comment) . clearenv also affects the process-wide environment.

@SteveLauC
Copy link
Member Author

The prctl stuff is in its own test program because it changes process-wide settings that might affect other tests. #1550 (comment) . clearenv also affects the process-wide environment.

Makes sense, they should be put in their own processes, close this PR

@SteveLauC SteveLauC closed this Nov 26, 2023
@SteveLauC SteveLauC deleted the test branch November 26, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants