-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cfg for test/* #2230
refactor: cfg for test/* #2230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but needs a rebase
test/sys/mod.rs
Outdated
target_os = "netbsd", | ||
target_os = "openbsd" | ||
))] | ||
#[cfg(any(linux_android, freebsdlike, netbsdlike, target_os = "macos"))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a candidate for apple_targets. I think ptrace defines all the same symbols for ios etc as for macos.
94be93c
to
79da01d
Compare
done |
Needs another. |
79da01d
to
0b2e61c
Compare
apple_targets, | ||
target_os = "netbsd", | ||
target_os = "openbsd", | ||
target_os = "solaris"))] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we have both solarish
and target_os = "solarish"
, this was accidentially introduced in #2248, in case you are curious about the reason
done |
What does this PR do
cfg for test/*.rs
This PR also applies the
netbsdlike
alias added in #2226Checklist:
CONTRIBUTING.md