refactor: enable most macOS funcs for apple_targets #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
commented
Dec 1, 2023
asomers
requested changes
Dec 1, 2023
changelog/2241.changed.md
Outdated
| @@ -0,0 +1 @@ | |||
| `ClockId::set_time()` has been disabled on iOS/tvOS/watchOS given that it is only available on macOS | |||
There was a problem hiding this comment.
It was already disabled on iOS/tvOS/watchOS. Shouldn't this read "ClockId::set_time is now enabled on macos" ?
src/time.rs
Outdated
Comment on lines
43
to
44
| #[cfg(not(any( | ||
| target_os = "macos", |
There was a problem hiding this comment.
Did you not notice the not ?
Suggested change
| #[cfg(not(any( | |
| target_os = "macos", | |
| #[cfg(not(any( | |
| target_os = "ios", | |
| target_os = "tvos", | |
| target_os = "watchos", |
There was a problem hiding this comment.
Oops, I am sorry I missed that, fixed!
asomers
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
ClockId::setime()andtime::clock_settime()on macOSCloses #2238
Checklist:
CONTRIBUTING.md