sys::mman adding MMAP_TRYFIXED for netbsdlike platforms. #2260

devnexen · 2023-12-10T08:43:41Z

No description provided.

SteveLauC · 2023-12-11T01:32:33Z

src/sys/mman.rs

@@ -154,6 +154,10 @@ libc_bitflags! {
        /// Pages will be discarded in the core dumps.
        #[cfg(target_os = "openbsd")]
        MAP_CONCEAL;
+        /// Attempt to place the mapping at exactly the address specified in `addr`.
+        /// it's a default behavior on openbsd.


Nit: Might be better if we change it to:

Suggested change

/// it's a default behavior on openbsd.

/// It's the default behavior on OpenBSD.

devnexen force-pushed the mman_netbsdlike branch 2 times, most recently from 3814872 to 418a2d5 Compare December 10, 2023 14:14

SteveLauC requested changes Dec 11, 2023

View reviewed changes

sys::mman adding MMAP_TRYFIXED for netbsdlike platforms.

f056c86

devnexen force-pushed the mman_netbsdlike branch from 418a2d5 to f056c86 Compare December 11, 2023 07:03

SteveLauC approved these changes Dec 11, 2023

View reviewed changes

SteveLauC added this pull request to the merge queue Dec 11, 2023

Merged via the queue into nix-rust:master with commit 8db0701 Dec 11, 2023
35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sys::mman adding MMAP_TRYFIXED for netbsdlike platforms. #2260

sys::mman adding MMAP_TRYFIXED for netbsdlike platforms. #2260

devnexen commented Dec 10, 2023

SteveLauC Dec 11, 2023

	/// it's a default behavior on openbsd.
	/// It's the default behavior on OpenBSD.

sys::mman adding MMAP_TRYFIXED for netbsdlike platforms. #2260

sys::mman adding MMAP_TRYFIXED for netbsdlike platforms. #2260

Conversation

devnexen commented Dec 10, 2023

SteveLauC Dec 11, 2023

Choose a reason for hiding this comment