feat: sockopt Ipv6Ttl for apple targets #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temporarily enabled that test for apple targets in this commit, and CI passed. |
asomers
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Add socket option
Ipv6Ttlfor apple targets.Checklist:
I have read
CONTRIBUTING.mdI have written necessary tests and rustdoc comments
There is a test (
test_ttl_opts()) forIpv4TtlandIpv6Ttl, but the support ofIpv4Ttlfor apple will be added in Support for socket options to get/set TOS/TTL info #2203, which means that I cannot enable that test in this PR, will do it when both of these PRs get merged.A change log has been added if this PR modifies nix's API