Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System V shared memory APIs (2nd draft) #2314

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

System V shared memory APIs (2nd draft) #2314

wants to merge 58 commits into from

Commits on Feb 13, 2024

  1. First try at implementing SystemV

    @IzawGithub
    IzawGithub committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    096cb21 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Add permission struct

    @IzawGithub
    IzawGithub committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    072352c View commit details
    Browse the repository at this point in the history

  2. Add crude semaphore support

    @IzawGithub
    IzawGithub committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    adeaaa2 View commit details
    Browse the repository at this point in the history

  3. Add documentation that was missing

    @IzawGithub
    IzawGithub committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    135488e View commit details
    Browse the repository at this point in the history

  4. Add PR changelog file

    @IzawGithub
    IzawGithub committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ac357e2 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Move SystemV to it's own file

    @IzawGithub
    IzawGithub committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    3f6a4c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Fix not compiling on Musl because of missing struct

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5047036 View commit details
    Browse the repository at this point in the history

  2. Fix clippy unsafe ptr arg dereference lint

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    b428de0 View commit details
    Browse the repository at this point in the history

  3. Formatting parse

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    07a6f33 View commit details
    Browse the repository at this point in the history

  4. Add missing import that I forgot to commit

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ac33ca0 View commit details
    Browse the repository at this point in the history

  5. Update doctest path that changed

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    11aad71 View commit details
    Browse the repository at this point in the history

  6. Add basic IPC test. 

    Next step would be to increase coverage by trying the different flags
    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    d8db9fa View commit details
    Browse the repository at this point in the history

  7. Fix using latest Rust feature that was unstable before

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    bd938e6 View commit details
    Browse the repository at this point in the history

  8. Forgot a formatting parse

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    b9a5905 View commit details
    Browse the repository at this point in the history

  9. Enable SystemV only for linux, but not Android 

    SystemV is disabled on Android, see [here](https://android.googlesource.com/platform/ndk/+/4e159d95ebf23b5f72bb707b0cb1518ef96b3d03/docs/system/libc/SYSV-IPC.TXT)
    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    50916a4 View commit details
    Browse the repository at this point in the history

  10. Update conditional compilation for GNU extension

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f3e4771 View commit details
    Browse the repository at this point in the history

  11. Fix macro not compiling for NetBSD

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9c71d97 View commit details
    Browse the repository at this point in the history

  12. Fix moving shmid_ds to GNU extension when it's not

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5d0d37c View commit details
    Browse the repository at this point in the history

  13. Fix mistake in conditional compilation that didn't disable SystemV fo… 

    …r android
    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    315eb31 View commit details
    Browse the repository at this point in the history

  14. Add back cfg that disable some flags for BSD

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9374dcf View commit details
    Browse the repository at this point in the history

  15. Final (I hope) formatting pass

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    bb07d5b View commit details
    Browse the repository at this point in the history

  16. Disable test for non systemV platform

    @IzawGithub
    IzawGithub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    19c713d View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Fix wrong changelog number and content

    @IzawGithub
    IzawGithub committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    17561e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Remove first try at SystemV, replacing with refractor

    @IzawGithub
    IzawGithub committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    2b76711 View commit details
    Browse the repository at this point in the history

  2. First try at refractoring SystemV to be more Rusty 

    Separated shared memory and semaphore
    @IzawGithub
    IzawGithub committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    94e4e11 View commit details
    Browse the repository at this point in the history

  3. Add a feature gate

    @IzawGithub
    IzawGithub committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    aea8588 View commit details
    Browse the repository at this point in the history

  4. Add missing doc

    @IzawGithub
    IzawGithub committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    02b0de2 View commit details
    Browse the repository at this point in the history

  5. Fix doctest copy and paste error

    @IzawGithub
    IzawGithub committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    ed99763 View commit details
    Browse the repository at this point in the history

  6. Remove Clone derive, wasn't working correctly

    @IzawGithub
    IzawGithub committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    b614d81 View commit details
    Browse the repository at this point in the history

  7. Update test to create an entirely new SharedMemory object 

    This way we can be sure the Shm is actually updated correctly by libc, and not just internally by Rust
    @IzawGithub
    IzawGithub committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    2629192 View commit details
    Browse the repository at this point in the history

  8. Misc formatting

    @IzawGithub
    IzawGithub committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    b7b8818 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Remove unused static mutex for system_v 

    Test are now internal to access private var
    @IzawGithub
    IzawGithub committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    930f352 View commit details
    Browse the repository at this point in the history

  2. Add Shm wrapper for creating a shared memory segment

    @IzawGithub
    IzawGithub committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    4bd41cf View commit details
    Browse the repository at this point in the history

  3. Remove function that create a memory segment from SharedMemory

    @IzawGithub
    IzawGithub committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    2c714c2 View commit details
    Browse the repository at this point in the history

  4. Make buf parameter pass by ref

    @IzawGithub
    IzawGithub committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    6877712 View commit details
    Browse the repository at this point in the history

  5. Remove the shmat enum value that work with incompatible void ptr

    @IzawGithub
    IzawGithub committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    b7f6a09 View commit details
    Browse the repository at this point in the history

  6. Update unit test

    @IzawGithub
    IzawGithub committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    d07c9b8 View commit details
    Browse the repository at this point in the history

  7. Update imported function

    @IzawGithub
    IzawGithub committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    5697ffd View commit details
    Browse the repository at this point in the history

  8. Remove stable ptr_from_ref feature that isn't stable on Rust 1.69

    @IzawGithub
    IzawGithub committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    3d70ae2 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Remove unused comment mark

    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    238fe62 View commit details
    Browse the repository at this point in the history

  2. Add back shmat address. Use a raw pointer.

    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    0ff180a View commit details
    Browse the repository at this point in the history

  3. Fix mismatched target os

    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    f5f2f59 View commit details
    Browse the repository at this point in the history

  4. Fix wrong comment formatting

    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    2803e31 View commit details
    Browse the repository at this point in the history

  5. Move shmctl function to Shm. 

    This make it possible to delete a memory segment without attaching.
    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    35c2f4e View commit details
    Browse the repository at this point in the history

  6. Update doctest

    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    d05db61 View commit details
    Browse the repository at this point in the history

  7. Remove id from SharedMemory don't need it now that shmctl isn't… 

    … here
    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ef1a839 View commit details
    Browse the repository at this point in the history

  8. Move test to independent file

    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e91efa3 View commit details
    Browse the repository at this point in the history

  9. Follow Nix module convention

    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    d96d5ee View commit details
    Browse the repository at this point in the history

  10. Update independent test import

    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    6aa8740 View commit details
    Browse the repository at this point in the history

  11. Rename system_v feature to sysvipc, like Linux

    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    fd108e4 View commit details
    Browse the repository at this point in the history

  12. Update doctest import path

    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    2fde2c5 View commit details
    Browse the repository at this point in the history

  13. Remove IPC_PRIVATE value from ShmgetFlag, because it wasn't actua… 

    …lly a flag
    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e531e8b View commit details
    Browse the repository at this point in the history

  14. Formatting parse

    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    fee5acb View commit details
    Browse the repository at this point in the history

  15. Update comment of function that moved

    @IzawGithub
    IzawGithub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    52473ce View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Fix typo test_smh to test_shm

    @IzawGithub
    IzawGithub committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d526780 View commit details
    Browse the repository at this point in the history

  2. Add a test for unsafe shmget. Branch coverage is now 89.29%

    @IzawGithub
    IzawGithub committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    400f71e View commit details
    Browse the repository at this point in the history

  3. Improve code comment

    @IzawGithub
    IzawGithub committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d619c48 View commit details
    Browse the repository at this point in the history

  4. Formatting parse

    @IzawGithub
    IzawGithub committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ca0c5f9 View commit details
    Browse the repository at this point in the history