Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add O_SEARCH to all platforms supported by libc crate #2374

Merged
merged 8 commits into from
Apr 21, 2024

Conversation

TheJonny
Copy link
Contributor

What does this PR do

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@TheJonny TheJonny changed the title Add O_SEARCH to freebsd and solarish Add O_SEARCH to freebsd, solarish, and fuchsia Apr 15, 2024
src/fcntl.rs Outdated Show resolved Hide resolved
@SteveLauC
Copy link
Member

Hi, thanks for contributing to Nix, this patch LGTM expect that alias:)

Co-authored-by: SteveLauC <stevelauc@outlook.com>
@TheJonny
Copy link
Contributor Author

Should we also add it in all the other platforms supported by libc that are not in the tier list of nix? that would be aix, wasi, emscripten ?

@SteveLauC
Copy link
Member

Should we also add it in all the other platforms supported by libc that are not in the tier list of nix? that would be aix, wasi, emscripten ?

Yeah, I think we can do this

@SteveLauC
Copy link
Member

Hi, would you still want to add this symbol for these platforms :)

@TheJonny
Copy link
Contributor Author

Hi, would you still want to add this symbol for these platforms :)

done - I just was scared by the long cfg line :)

@TheJonny
Copy link
Contributor Author

(I would also like to see it on apple, but it's currently missing from libc - rust-lang/libc#3659 )

@TheJonny TheJonny changed the title Add O_SEARCH to freebsd, solarish, and fuchsia Add O_SEARCH to all platforms supported by libc crate Apr 21, 2024
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SteveLauC SteveLauC added this pull request to the merge queue Apr 21, 2024
Merged via the queue into nix-rust:master with commit 7ffbd3c Apr 21, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants