fix ControlMessageOwned::UdpGroSegments UDP packets processing type. #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
reviewed
May 17, 2024
changelog/2406.changed.md
Outdated
There was a problem hiding this comment.
Kinda think this changelog should be named "2406.fixed.md" considering that reading an u16 using std::ptr::read_unaligned() from an i32 buffer would not work on big-endian machines
devnexen
force-pushed
the
udpgrosegment_type_fix
branch
from
6cef4de
to
47fdb57
Compare
|
CI failure is not related to this PR, libc 0.2.154 has been yanked, we have to wait for the release of 0.2.155. |
|
The issue has been fixed, please rebase your branch:) |
The kernel, since 5.0, process the segmentation offload with a signed int. close nix-rust#2403.
devnexen
force-pushed
the
udpgrosegment_type_fix
branch
from
47fdb57
to
1c61c60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel, since 5.0, process the segmentation offload with a signed int.
close #2403.