Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove test of inode count in test_statfs.rs #2414

Merged
merged 2 commits into from
May 22, 2024

Conversation

SteveLauC
Copy link
Member

What does this PR do

This PR removes the test of inode count in test/sys/test_statfs.rs since it sometimes fails the CI on macOS, see issue #2411.

We don't want to bother with the issue, and actually we don't need to since we only need to ensure the Rust binding is working, so remove it.

Closes #2411

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@@ -93,7 +92,6 @@ fn assert_fs_equals_strict(fs: Statfs, vfs: Statvfs) {
assert_eq!(fs.files_free() as u64, vfs.files_free() as u64);
assert_eq!(fs.blocks_free() as u64, vfs.blocks_free() as u64);
assert_eq!(fs.blocks_available() as u64, vfs.blocks_available() as u64);
assert_eq!(fs.files() as u64, vfs.files() as u64);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should leave the check in assert_fs_equals_strict. This function contains other assertions that are even more likely to fail, but it's only called from #[ignore] tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@SteveLauC SteveLauC added this pull request to the merge queue May 22, 2024
Merged via the queue into nix-rust:master with commit ecd12a9 May 22, 2024
36 checks passed
@SteveLauC SteveLauC deleted the test/remove_inode_test branch May 22, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test statfs_call() fails on macOS because statfs() and statvfs() report different number of i-nodes
2 participants