Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast function item to function pointer in order to appease compiler. #353

Merged
merged 1 commit into from
Apr 18, 2016
Merged

Cast function item to function pointer in order to appease compiler. #353

merged 1 commit into from
Apr 18, 2016

Conversation

fiveop
Copy link
Contributor

@fiveop fiveop commented Apr 14, 2016

This is necessary because of compiler changes. For further information
look at rust-lang/rust#19925.

This solves #346.

I know that there are other problems with the affected function. We are thinking about how to best pass the arguments to the function and we don't want to define the ffi's ourselves. However, I would like to get the warning out of our tree as soon as possible. We do not need to wait for our polish.

This is necessary because of compiler changes. For further information
look at rust-lang/rust#19925.
@kamalmarhubi
Copy link
Member

However, I would like to get the warning out of our tree as soon as possible. We do not need to wait for our polish.

👍

@homu r+ 47dc5fe

homu added a commit that referenced this pull request Apr 18, 2016
Cast function item to function pointer in order to appease compiler.

This is necessary because of compiler changes. For further information
look at rust-lang/rust#19925.

This solves #346.

I know that there are other problems with the affected function. We are thinking about how to best pass the arguments to the function and we don't want to define the ffi's ourselves. However, I would like to get the warning out of our tree as soon as possible. We do not need to wait for our polish.
@homu
Copy link
Contributor

homu commented Apr 18, 2016

⌛ Testing commit 47dc5fe with merge 9d912ae...

@homu
Copy link
Contributor

homu commented Apr 18, 2016

☀️ Test successful - status

@homu homu merged commit 47dc5fe into nix-rust:master Apr 18, 2016
@fiveop fiveop deleted the nightly_warning branch May 1, 2016 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants