Added lseek and seek64 #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tmp.read_to_string(&mut buf).unwrap(); | ||
| assert_eq!(b"f123456", buf.as_bytes()); | ||
|
|
||
| close(tmp.as_raw_fd()).unwrap(); |
There was a problem hiding this comment.
nit: spacing in function seems inconsistent (some of it is 5 spaces)
There was a problem hiding this comment.
Sorry about that, I rushed a bit, I will fix it.
|
Please also squash commits down to a single commit as well. |
llseek and lseek64 impl Whence fixed formatting awful typo when refactoring no llseek wrong test name using off64_t got rid of offset Added SeekHole/Data; formatted test; SeekCur/Set/End use libc constants
|
All done, let me know if anything else has to be fixed. |
|
Sorry for the delay @aoprisan. A couple minor things remain, but we can probably address these in the future:
That being said, that can all be fixed later. So, @homu r+ |
|
📌 Commit 0eb8b4b has been approved by |
homu
added a commit
that referenced
this pull request
Jun 20, 2016
Added lseek and seek64 I have added lseek and seek64 to unistd, the last one targeting Linux/Android only. I wasn't sure where to place the Whence enum, or if it's a nice of doing, I am quite fresh to Rust.
posborne
added a commit
to posborne/libc
that referenced
this pull request
Jun 20, 2016
Relates to nix-rust/nix#377. These constants are only available in systems running the Linux kernel. Signed-off-by: Paul Osborne <osbpau@gmail.com>
posborne
added a commit
to posborne/libc
that referenced
this pull request
Jun 21, 2016
Relates to nix-rust/nix#377. These constants are only available in systems running the Linux kernel and are not defined in musl libc (yet). Signed-off-by: Paul Osborne <osbpau@gmail.com>
bors
added a commit
to rust-lang/libc
that referenced
this pull request
Jun 21, 2016
Add SEEK_DATA/SEEK_HOLE constants Relates to nix-rust/nix#377. These constants are only available in systems running the Linux kernel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added lseek and seek64 to unistd, the last one targeting Linux/Android only. I wasn't sure where to place the Whence enum, or if it's a nice of doing, I am quite fresh to Rust.