Change SigFlags into an enum.

[chaosagent]

Addresses #459.

This is a breaking change.

Should SigFlags be renamed to something more sensible?

[fiveop]

The PR looks good.

I agree that the name should be different. I cannot think of a good naming convention that would work for all enumerations (e.g. SigEnum just does not tell us anything). Therefore, I would propose to go with SigHow.

In addition, could you please add an entry to CHANGELOG.md describing the breaking change.

[chaosagent]

I was thinking of something like SigmaskHow since this enum only applies to to the pthread_sigmask and the sigmask (unimplemented in nix) calls but not the rest of the signal functions. In contrast, SigSet applies to both sigaction and sigmask, so it deserves to be labelled generically as Sig. Another possibility is to just use Request as the standard way to specify how-like values in the library like with PtraceRequest, which is actually enumerated in C libc [1], but using How might be advantageous in that it reflects the argument names in libc. Thoughts?

I'm probably making way too much of a fuss about naming though ;)

I'll hold off on the CHANGELOG changes until we figure this out I guess.
[1] http://man7.org/linux/man-pages/man2/ptrace.2.html

[chaosagent]

I went ahead and pushed a rename to SigmaskHow and an entry in CHANGELOG.md.

[fiveop]

One last tiny request.

[fiveop]

Link name is #410 instead of #460.

[fiveop]

I'll just fix it in a separate commit.

[fiveop]

@homu r+

[homu]

📌 Commit e19f142 has been approved by fiveop

[homu]

⌛ Testing commit e19f142 with merge 8cda34d...

[homu]

☀️ Test successful - status

[homu]

☀️ Test successful - status