Add AioCb::from_boxed_slice #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2017
posborne
reviewed
Apr 16, 2017
src/sys/aio.rs
Outdated
| /// Keeps a reference to a Boxed slice | ||
| boxed(Rc<Box<[u8]>>), | ||
| /// Keeps a reference to a slice | ||
| phantom(PhantomData<&'a mut [u8]>) |
There was a problem hiding this comment.
nit: Indentation on this block seems off
|
One super minor nit, but otherwise the change looks good to me. |
|
good catch. I'll fix it and merge. |
|
bors r+ |
Merge conflict |
|
☔ The latest upstream changes (presumably 8c47de4) made this pull request unmergeable. Please resolve the merge conflicts. |
The existing AioCb constructors work for simple programs where everything is stored on the stack. But in more complicated programs the borrow checker can't prove that a buffer will outlive the AioCb that references it. Fix this problem by introducting AioCb::from_boxed_slice, which takes a reference-counted buffer. Fixes nix-rust#575
|
bors +r |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 16, 2017
582: Add AioCb::from_boxed_slice r=posborne The existing AioCb constructors work for simple programs where everything is stored on the stack. But in more complicated programs the borrow checker can't prove that a buffer will outlive the AioCb that references it. Fix this problem by introducting AioCb::from_boxed_slice, which takes a reference-counted buffer. Fixes #575
|
thanks @posborne . I obviously need to work on my bors-foo. |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing AioCb constructors work for simple programs where
everything is stored on the stack. But in more complicated programs the
borrow checker can't prove that a buffer will outlive the AioCb that
references it. Fix this problem by introducting
AioCb::from_boxed_slice, which takes a reference-counted buffer.
Fixes #575