Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate the FreeBSD BuildBot #618

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Integrate the FreeBSD BuildBot #618

merged 1 commit into from
Jun 5, 2017

Conversation

asomers
Copy link
Member

@asomers asomers commented Jun 4, 2017

  • Gate Bors on the FreeBSD 11 build
  • Remove the testless FreeBSD build from Travis
  • Promote x86_64-unknown-freebsd to Tier 1

Fixes #603

@asomers asomers requested a review from Susurrus June 4, 2017 19:48
Susurrus
Susurrus suggested changes Jun 4, 2017
View reviewed changes
bors.toml Outdated
status = ["continuous-integration/travis-ci/push"]
# Gate on Travis CI and Buildbot
status = ["continuous-integration/travis-ci/push",
"buildbot/nix-rust/nix fbsd11"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, can you align the quotes? The off-by-two is bugging me.

@Susurrus
Copy link
Contributor

Susurrus commented Jun 4, 2017

This seems to only address x86_64 FreeBSD, do you have plans for i686? Or was #603 really just about x86_64?

@Susurrus Susurrus mentioned this pull request Jun 4, 2017
Merged
@Susurrus
Copy link
Contributor

Susurrus commented Jun 4, 2017

After my one comment is resolved, this LGTM.

@asomers
Integrate the FreeBSD BuildBot
9286ab6 
* Gate Bors on the FreeBSD 11 build
* Remove the testless FreeBSD build from Travis
* Promote x86_64-unknown-freebsd to Tier 1

Fixes nix-rust#603
@asomers
Copy link
Member Author

asomers commented Jun 4, 2017

@Susurrus it would be pretty easy to add an x86 worker. I'd like to do it, but I haven't gotten around to it yet. It would also be totally awesome to have an arm64 worker, which will be possible as soon as Scaleway.com's ARM64 VPSes go live. Right now they're just in preview mode.

@Susurrus
Copy link
Contributor

Susurrus commented Jun 4, 2017

Let's do this.

bors r+

bors bot added a commit that referenced this pull request Jun 4, 2017
@bors
Merge #618
4b78c43 
618: Integrate the FreeBSD BuildBot r=Susurrus
* Gate Bors on the FreeBSD 11 build
* Remove the testless FreeBSD build from Travis
* Promote x86_64-unknown-freebsd to Tier 1

Fixes #603
@bors
Copy link
Contributor

bors bot commented Jun 5, 2017

Timed out

@notriddle
Copy link
Contributor

Try again? BuildBot didn't build the merge commit (based on clicking the X and seeing fbsd11 not listed), but it built the newer commits done afterward (because fbsd11 is listed under the checkmark).

@asomers
Copy link
Member Author

asomers commented Jun 5, 2017

I noticed that. I changed one thing in BuildBot's configuration, but I didn't expect it to solve this particular problem. I guess we may as well try, try again. The worst case is that BuildBot is intermittent. If that happens, we'll have to degate Bors on it.
bors r+

bors bot added a commit that referenced this pull request Jun 5, 2017
@bors
Merge #618
41b8638 
618: Integrate the FreeBSD BuildBot r=asomers
* Gate Bors on the FreeBSD 11 build
* Remove the testless FreeBSD build from Travis
* Promote x86_64-unknown-freebsd to Tier 1

Fixes #603
@bors
Copy link
Contributor

bors bot commented Jun 5, 2017

Build succeeded

@bors bors bot merged commit 9286ab6 into nix-rust:master Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Susurrus Susurrus Susurrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asomers @Susurrus @notriddle