merge socket constants #646
Conversation
ndusart
force-pushed
the
master
branch
3 times, most recently
from
830efc3
to
7ed7cf3
Compare
src/sys/socket/consts.rs
Outdated
| pub const IPPROTO_UDP: c_int = SOL_UDP; | ||
| #[cfg(any(target_os = "macos", target_os = "freebsd", target_os = "ios", target_os = "openbsd", target_os = "netbsd"))] |
There was a problem hiding this comment.
This line's too long. Please wrap lines to 100 characters. In this case, I like aligning all the target_os sections vertically. This applies to many other lines here, so please fix it for all of them.
There was a problem hiding this comment.
Should I split target_os in several lines for each case, or only when the line is longer than 100 characters ?
…rent architectures
|
Don't know why but buildbot keep failing at fetching the code.. |
|
I don't know why either, but buildbot is trying a different sequence of commands for this build than it uses for most PRs. Compare https://alan.ci/buildbot/#/builders/5/builds/200/steps/0/logs/stdio (this PR) to https://alan.ci/buildbot/#/builders/5/builds/79/steps/0/logs/stdio (PR 624). I wonder if it's confused because your branch name is master? Its my only guess at this point. |
|
Buildbot actually made two tests for each of my commits: For the last one: The first one succeeded though. It's probably the name of my branch, I should take the habit to avoid working directly on the master branch once I fork the repo. Do I need to create a new PR with another branch ? |
|
@ndusart Could you try filing another PR using a feature branch? Then we can check if that's indeed the issue. |
|
This seems to be effectively the issue ! Succeed now with the new PR. |
|
That's annoying. @asomers Looks like another bug that should be filed with the upstream buildbot project. |
|
Closing in favor of #647. |
647: merge socket constants r=Susurrus > Refactor the constant declarations such that all constants are only declared once with a #[cfg] that only enables the constant on the correct platforms. Closes #637 (same PR as #646 but from another branch, to see if buildbot has a problem with PR made from master branch)
#637