ptrace: add PTRACE_O_EXITKILL option #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bpowers no, there's no way to conditionally build stuff based on kernel version. It's up to the application to check for |
Susurrus
suggested changes
Oct 18, 2017
src/sys/ptrace.rs
Outdated
| @@ -116,6 +116,10 @@ libc_bitflags! { | |||
| /// Stop tracee when a SECCOMP_RET_TRACE rule is triggered. See `man seccomp` for more | |||
| /// details. | |||
| PTRACE_O_TRACESECCOMP; | |||
| /// Send a SIGKILL to the tracee if the tracer exits. This is useful | |||
| /// for ptrace jailers to prevent tracees from escaping their control. | |||
| #[cfg(target_os = "linux")] | |||
There was a problem hiding this comment.
This should be available on Android as well. Please keep the OSes listed in alphabetical order here.
There was a problem hiding this comment.
good catch! updated diff.
It is a somewhat newer option -- it requires Linux 3.8.
Susurrus
approved these changes
Oct 31, 2017
|
that errored Travis test is unrelated to this -- seems to be some NetBSD problem? |
|
bors r+ |
|
awesome, thanks!! |
|
Thank you for your contribution to nix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a somewhat newer option -- it requires Linux 3.8. Is there a
more precise way to specify that?