#602 added unistd::mkfifo

[jpastuszek]

Since libc has mkfifo already I have just copied mkdir and adapted to mkfifo. I have tested that on MacOS only.

[asomers]

Odd that you apparently develop on OSX but reference Linux man pages. However, nix is cross-platform, so the best man pages to use are opengroup's. Could you please change the link to this?
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/mkfifo.html

[jpastuszek]

Well not that odd considering all other man page links in that file are pointing to http://man7.org/linux.

[asomers]

Yeah, we've been slowly moving them as we go, but we haven't mass-converted.

[asomers]

Could you also please add an entry to the CHANGELOG?

[Mic92]

you can probably adapt the tests from the code I made here: https://github.com/nix-rust/nix/pull/751/files#diff-899c5a4ff7ee773df222af8874b4761eR115

[jpastuszek]

Is there anything else needed for this PR?

[asomers]

Just a squash, then I'll merge it.

[jpastuszek]

Squashed. Thank you.

[asomers]

bors r+

[bors]

Build succeeded

• buildbot/nix-rust/nix amd64_fbsd11
• buildbot/nix-rust/nix i386_fbsd11
• continuous-integration/travis-ci/push

[asomers]

Sorry, but I just noticed one more problem: mkfifo belongs in src/sys/stat.rs, not src/unistd.rs, because its C prototype is located in sys/stat.h.

[asomers]

Damn my out-of-date browser windows! I guess this one slipped by.

[jpastuszek]

Sorry, my bad. I should have read the comment on the top of the file.
My reasoning was that mkfifo is like mkdir or other kind of function that crates objects in the file system so I just placed it beside it...

You may also want to consider moving mkdir so others won't make this mistake in the future:

NAME
     mkdir, mkdirat -- make a directory file

SYNOPSIS
     #include <sys/stat.h>

     int
     mkdir(const char *path, mode_t mode);

NAME
     mkfifo -- make a fifo file

SYNOPSIS
     #include <sys/types.h>
     #include <sys/stat.h>

     int
     mkfifo(const char *path, mode_t mode);

From http://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/stat.h.html:

The following shall be declared as functions and may also be defined as macros. Function prototypes shall be provided.

int    chmod(const char *, mode_t);
int    fchmod(int, mode_t);
int    fstat(int, struct stat *);
int    lstat(const char *restrict, struct stat *restrict);
int    mkdir(const char *, mode_t);
int    mkfifo(const char *, mode_t);
[XSI][Option Start]
int    mknod(const char *, mode_t, dev_t);
[Option End]
int    stat(const char *restrict, struct stat *restrict);
mode_t umask(mode_t);

And indeed the http://pubs.opengroup.org/onlinepubs/7908799/xsh/unistd.h.html does not list mkfifo or mkdir.

Do you want me to do something about this?