Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added getsid in ::nix::unistd #851

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Added getsid in ::nix::unistd #851

merged 2 commits into from
Feb 6, 2018

Conversation

ggriffiniii
Copy link
Contributor

Resolves Issue #850

@asomers
Copy link
Member

asomers commented Feb 3, 2018

Could we get a test here?

@ggriffiniii
Copy link
Contributor Author

Any suggestions what the test should assert? I looked at setsid, getpgid, setpgid, to try and get an idea what appropriate behavior to test would be, but I didn't see any test cases for those functions.

@asomers
Copy link
Member

asomers commented Feb 3, 2018

If nothing else, a doc test demonstrating usage would be good. You could also get that getsid(None) == getsid(Some(getpid()))

@ggriffiniii
Copy link
Contributor Author

Test added

@asomers
Copy link
Member

asomers commented Feb 6, 2018

bors r+

bors bot added a commit that referenced this pull request Feb 6, 2018
@bors
Merge #851
90e82ed 
851: Added `getsid` in `::nix::unistd` r=asomers a=ggriffiniii

Resolves Issue #850
@bors
Copy link
Contributor

bors bot commented Feb 6, 2018

Build succeeded

@bors bors bot merged commit 5e99945 into nix-rust:master Feb 6, 2018
@Susurrus Susurrus mentioned this pull request Feb 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggriffiniii @asomers