Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelog for #869 #880

Merged
merged 1 commit into from
May 2, 2018
Merged

Update changelog for #869 #880

merged 1 commit into from
May 2, 2018

Conversation

Detegr
Copy link
Contributor

@Detegr Detegr commented Apr 4, 2018

Updated changelog to contain #869

@Detegr
Copy link
Contributor Author

Detegr commented Apr 4, 2018

Whoops, forgot to edit the PR title. Oh well...

@Susurrus Susurrus changed the title [skip ci] Update changelog for #869 Update changelog for #869 Apr 4, 2018
@Susurrus
Copy link
Contributor

Susurrus commented Apr 4, 2018

This was a bug fix though, correct? If so, this should be under the Fixed section. Probably should be stated as "Fixed panics when using SigAction::flags() in some situations on Linux". Does that seem like a succinct and correct description?

@Detegr
Copy link
Contributor Author

Detegr commented May 1, 2018

Sure. I'm sorry this took so long.

asomers
asomers approved these changes May 1, 2018
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll give susurrus 24 hours to chime in before I merge.

@Susurrus
Copy link
Contributor

Susurrus commented May 2, 2018

Thanks, Detegr!

bors r+

bors bot added a commit that referenced this pull request May 2, 2018
@bors @Detegr
Merge #880
ba402c0 
880: Update changelog for #869 r=Susurrus a=Detegr

Updated changelog to contain #869

Co-authored-by: Antti Keränen <detegr@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 2, 2018

Build succeeded

@bors bors bot merged commit 094270f into nix-rust:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Detegr @Susurrus @asomers