Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sys::stat::mode_t public #954

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Make sys::stat::mode_t public #954

merged 1 commit into from
Oct 17, 2018

Conversation

jmmv
Copy link
Contributor

@jmmv jmmv commented Oct 17, 2018

This allows using e.g. sys::stat::Mode::from_bits() without having to
pull the mode_t type from libc (which is ugly if a project is trying
to use nix exclusively to avoid libc's unsafety).

This change mimics dev_t which was already exposed as public.

This allows using e.g. sys::stat::Mode::from_bits() without having to
pull the mode_t type from libc (which is ugly if a project is trying
to use nix exclusively to avoid libc's unsafety).

This change mimics dev_t which was already exposed as public.
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bors r+

bors bot added a commit that referenced this pull request Oct 17, 2018
954: Make sys::stat::mode_t public r=asomers a=jmmv

This allows using e.g. sys::stat::Mode::from_bits() without having to
pull the mode_t type from libc (which is ugly if a project is trying
to use nix exclusively to avoid libc's unsafety).

This change mimics dev_t which was already exposed as public.

Co-authored-by: Julio Merino <julio@meroh.net>
@bors
Copy link
Contributor

bors bot commented Oct 17, 2018

@bors bors bot merged commit ea6ed5a into nix-rust:master Oct 17, 2018
@jmmv jmmv deleted the mode_t branch October 17, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants