Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement symlinkat #997

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Implement symlinkat #997

merged 1 commit into from
Dec 12, 2018

Conversation

oblique
Copy link
Contributor

@oblique oblique commented Dec 11, 2018

No description provided.

@asomers
Copy link
Member

asomers commented Dec 11, 2018

Does this symlink have any advantages over std::os::unix::fs::symlink? If not, then I don't think we should provide a redundant binding.

@oblique
Copy link
Contributor Author

oblique commented Dec 11, 2018

No. However it is convenient when someone wants to write a function that returns nix::Error.

@asomers
Copy link
Member

asomers commented Dec 11, 2018

I don't think that's important enough to justify the bloat. Please remove symlink. Keep symlinkat though; that's useful.

@oblique
Copy link
Contributor Author

oblique commented Dec 11, 2018

Ready

@asomers
Copy link
Member

asomers commented Dec 11, 2018

LGTM. Just make sure it's all wrapped to 80 columns and add a CHANGELOG entry.

@oblique oblique changed the title Implement symlink and symlinkat Implement symlinkat Dec 12, 2018
asomers
asomers approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Dec 12, 2018
@bors @oblique
Merge #997
51bd085 
997: Implement symlinkat r=asomers a=oblique



Co-authored-by: oblique <psyberbits@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 12, 2018

Build succeeded

@bors bors bot merged commit 98ac441 into nix-rust:master Dec 12, 2018
@oblique oblique deleted the symlink branch December 12, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oblique @asomers