Fix header includes. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2023 13:39
Now builds with gcc-12 and gcc-13 Closes nixcloud#31 Closes nixcloud#30
Cleanup by running the fix-includes.py script from include-what-you-use and manually looking over and editing the resulting changes.
|
Ah, never mind... just saw your branch and might give it a shot to integrate later. |
|
I wasn't able to find a way to run it via meson. Hopefully the history of modifications in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #31 it was suggested that cleaning up the imports was something worth doing.
This includes the fixes for #30 and #31, and I think cleans up other imports as well.
The changes come from running the include-what-you-use tools, and then manually editing changes that were suggested.
I do have nix dev-shell set up in my
import-fix-wipbranch. Usinginclude-what-you-useas nix tool seems to be broken. The dev-shell is based on work on the branch by @Et73f that I found when reading NixOS/nixpkgs#189753The devShell isn't part of this CR