Bug Fixes and Performance Improvements

nixrajput · Jul 23, 2024 · 16b3a3f
1 parent 8add509
commit 16b3a3f
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 15 deletions.
diff --git a/src/Bus.cpp b/src/Bus.cpp
@@ -13,14 +13,14 @@ using namespace std;
 // Initialie variables in constructor
 Bus::Bus()
 {
-    strcpy(busNo, "");
+    strlcpy(busNo, "");
     maxSeats = 32;
     bookedSeats = 0;
     busFare = 0.0;
-    strcpy(source, "");
-    strcpy(destination, "");
-    strcpy(sourceTime, "");
-    strcpy(destinationTime, "");
+    strlcpy(source, "");
+    strlcpy(destination, "");
+    strlcpy(sourceTime, "");
+    strlcpy(destinationTime, "");
 }
 
 // Display bus details

diff --git a/src/Bus.h b/src/Bus.h
@@ -3,6 +3,8 @@
 
 #include <iostream>
 
+#include "utils.h"
+
 using namespace std;
 
 // BUS CLASS
@@ -82,25 +84,25 @@ class Bus
     void setSource(char *s)
     {
         if (s && s[0])
-            strcpy(source, s);
+            strlcpy(source, s);
     }
 
     void setDestination(char *d)
     {
         if (d && d[0])
-            strcpy(destination, d);
+            strlcpy(destination, d);
     }
 
     void setSourceTime(char *s)
     {
         if (s && s[0])
-            strcpy(sourceTime, s);
+            strlcpy(sourceTime, s);
     }
 
     void setDestinationTime(char *d)
     {
         if (d && d[0])
-            strcpy(destinationTime, d);
+            strlcpy(destinationTime, d);
     }
 
     void setBusFare(double f)

diff --git a/src/Reservation.cpp b/src/Reservation.cpp
@@ -16,9 +16,9 @@ Reservation::Reservation() {}
 // Generate a ticket
 void Reservation::_generateTicket(char *n, Bus b)
 {
-    strcpy(name, n);
-    strcpy(pnrNo, generatePNR(99999).c_str());
-    strcpy(date, getCurrentDate().c_str());
+    strlcpy(name, n);
+    strlcpy(pnrNo, generatePNR(99999).c_str());
+    strlcpy(date, getCurrentDate().c_str());
     bus = b;
 }
 

diff --git a/src/Reservation.h b/src/Reservation.h
@@ -4,6 +4,7 @@
 #include <iostream>
 
 #include "Bus.h"
+#include "utils.h"
 
 // RESERVATION CLASS
 class Reservation
@@ -49,7 +50,7 @@ class Reservation
     void setName(char *n)
     {
         if (n && n[0])
-            strcpy(name, n);
+            strlcpy(name, n);
     }
 };
 

diff --git a/src/utils.h b/src/utils.h
@@ -3,7 +3,10 @@
 
 #include <cstdlib>
 #include <string>
+#include <cstring>
+#include <limits>
 #include <ctime>
+#include <stddef.h>
 
 using namespace std;