Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #306 - fix examples - add CS/SS pin in begin method #307

Closed
wants to merge 1 commit into from

Conversation

valqk
Copy link

@valqk valqk commented Apr 18, 2018

I've fixed the examples so they can work with the CS/SS pin argument of the begin method.
It was getting stalled without it.

@njh
Copy link
Owner

njh commented Jul 27, 2018

Which boards were you testing with?

The EtherCard default to the value of the SS macro (10 on Uno), which is what most of the available ENC28J60 boards use for Slave Select.

However the Nanode does use pin 8.

I think changing to 8 would make it work for fewer people, not more.

@valqk
Copy link
Author

valqk commented Jul 28, 2018

ENC28J60 + Nano... you are right. Maybe this should just have to be 10 by default and in the comment then with proper attention for that. The main issue was I didn't know what was going on for some time and it took me a while while I find SS is passed as an argument. In the examples I firstly opened there was no SS for the init... maybe all examples should have the 10?
And in the comment something like
'Important: nano uses pin 8 for SS. If ss is not set properly the begin will stall. Default value for begin is 10 (used for Uno boards).'

@njh
Copy link
Owner

njh commented Jul 28, 2018

Replaced by #321

@njh njh closed this Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants