Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CMake build system #98

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add CMake build system #98

wants to merge 3 commits into from

Conversation

Be-ing
Copy link

@Be-ing Be-ing commented Aug 16, 2021

I am packaging twolame in vcpkg for Tenacity and do not want to deal with Visual Studio project files.

@Be-ing
Copy link
Author

Be-ing commented Aug 16, 2021

The GitHub Actions runs won't show up on pull requests for this repo until this is merged. In the meantime you can see the results on my fork: https://github.com/Be-ing/twolame/actions

@Be-ing
Copy link
Author

Be-ing commented Sep 16, 2021

ping

@generic-pers0n
Copy link

I’ll give this a bump to @njh even though this PR has sat inactive for more than 2 years.

I’ll be quite honest here: I’m a little eager, perhaps too eager, to see this PR merged. Particularly, I want to upstream an existing TwoLAME port that currently uses this branch, and I prefer to use upstream sources wherever possible. I also believe there are other benefits to using CMake over Autotools as a build system, particularly Ninja for faster builds and modern versions of Visual Studio. In the case of the latter, you wouldn’t need to maintain the ancient Visual Studio Project files anymore and let them be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants