-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in hbar #106
Labels
Comments
Fixed in #107 |
Additional typos were discovered for the electron and He3 (helion) mass values, reported by @kahlerac. These have been fixed in bugfix/constants. |
Merged
Fixed additional issues in #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After refactoring the constants into the phys.f90 file, hbar (in erg) is defined as:
real(kr),parameter,public::hbar=6.58219514e-16_kr*ev !Planck/2pi, erg
The numerical value has a missing digit in it, it should be:
real(kr),parameter,public::hbar=6.582119514e-16_kr*ev !Planck/2pi, erg
E.g. see ENDF manual appendix H.
Be aware that this minor difference has an impact on the 4th or 5th significant digit of all cross section values coming out of NJOY and has been present in the code since 27 days. This will be fixed as soon as possible.
The text was updated successfully, but these errors were encountered: