Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in hbar #106

Closed
whaeck opened this issue Oct 10, 2018 · 3 comments
Closed

Typo in hbar #106

whaeck opened this issue Oct 10, 2018 · 3 comments
Assignees
@whaeck
Labels
bug

Comments

@whaeck
Copy link
Member

whaeck commented Oct 10, 2018 •
edited
Loading

After refactoring the constants into the phys.f90 file, hbar (in erg) is defined as:
real(kr),parameter,public::hbar=6.58219514e-16_kr*ev !Planck/2pi, erg

The numerical value has a missing digit in it, it should be:
real(kr),parameter,public::hbar=6.582119514e-16_kr*ev !Planck/2pi, erg

E.g. see ENDF manual appendix H.

Be aware that this minor difference has an impact on the 4th or 5th significant digit of all cross section values coming out of NJOY and has been present in the code since 27 days. This will be fixed as soon as possible.
@whaeck whaeck added the bug label Oct 10, 2018
@whaeck whaeck self-assigned this Oct 10, 2018
whaeck added a commit that referenced this issue Oct 11, 2018
@whaeck
Corrected value of hbar, see issue #106
b1cf20d
@whaeck whaeck mentioned this issue Oct 11, 2018
Merged
@whaeck
Copy link
Member Author

whaeck commented Oct 16, 2018

Fixed in #107

@whaeck whaeck closed this as completed Oct 16, 2018
@whaeck whaeck reopened this Nov 19, 2018
whaeck added a commit that referenced this issue Nov 19, 2018
@whaeck
Corrected electron and helion mass constants - see #106
03491af
@whaeck
Copy link
Member Author

whaeck commented Nov 19, 2018

Additional typos were discovered for the electron and He3 (helion) mass values, reported by @kahlerac. These have been fixed in bugfix/constants.

@whaeck whaeck mentioned this issue Nov 19, 2018
Merged
@whaeck
Copy link
Member Author

whaeck commented Nov 20, 2018

Fixed additional issues in #115

@whaeck whaeck closed this as completed Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whaeck whaeck

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whaeck