Fix/acer temp #256
Merged
Fix/acer temp #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RECONR if we have processed MF12 sections (LO=1 only)
whaeck
requested review from
kahlerac
and removed request for
nathangibson14
kahlerac
previously approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Looks good to me. Coupled with Romano's positive feedback I'd say this is complete. But let's keep JCS's caution in mind for other NJOY modules (e.g., GROUPR, THERMR, ...). This isn't the first time a multi-temperature pendf has confused downstream NJOY modules.
|
@kahlerac Yes, I'll keep an eye out. Due to the previous merge, there's a conflict so I'll fix that and merge. |
|
@kahlerac You'll have to press the accept button again |
|
@kahlerac Sorry, I meant you need to reapprove this. |
kahlerac
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250