Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/std ranges part2 #11

Merged
merged 17 commits into from
Apr 22, 2024
Merged

Feature/std ranges part2 #11

merged 17 commits into from
Apr 22, 2024

Conversation

whaeck
Copy link
Member

@whaeck whaeck commented Mar 8, 2024

More nanorange being added. In this particular PR, we have added nanorange's iterator concepts and the common_iterator. Unit tests were added as well.

The unit tests compile on intel-classic/2022 and intel-classic/2023.

@whaeck whaeck requested a review from nathangibson14 March 8, 2024 02:56
@whaeck whaeck requested a review from mswwilson April 9, 2024 16:46
Base automatically changed from feature/std-ranges to develop April 15, 2024 17:40
//using namespace njoy::tools;
namespace std20 = nano::ranges;

SCENARIO( "invoke" ) {
Copy link

@mswwilson mswwilson Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scenario name "identity" instead of "invoke" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a copy/paste error.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put all updates following the reviews of these PRs to the fix/review branch.

@whaeck whaeck merged commit 9017525 into develop Apr 22, 2024
8 checks passed
@whaeck whaeck deleted the feature/std-ranges-part2 branch April 22, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants