Fix combat mode errors #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes units becoming stuck in combat mode Fixes units being triggered to enter combat/contact mode due to friendly fire 1. Changes the share information feature to trigger a more directly hiding. 2. Prevents all tactics level actions from setting behaviour 3. Small fix brain.sqf to "FIRE" and other immediate actions to sort friendly units* *For a small sake of performance I'm not sorting for all friendly sides-- Instead I am focused only on units which are the same _side_ as the shooter. Especially as it seems like allied sides trigger combat behaviour regardless.
nk3nny
commented
Oct 25, 2021
| @@ -88,7 +88,7 @@ if (_dangerCause isEqualTo DANGER_ASSESS) exitWith { | |||
|
|
|||
| // immediate actions | |||
| if (_dangerCause in [DANGER_HIT, DANGER_BULLETCLOSE, DANGER_EXPLOSION, DANGER_FIRE]) exitWith { | |||
| _return set [ACTION_IMMEDIATE, true]; | |||
| _return set [ACTION_IMMEDIATE, (side _group) isNotEqualTo side (group _dangerCausedBy)]; | |||
There was a problem hiding this comment.
I guess if we were really worried we could do:
!([side _group, side group _dangerCausedBy] call BIS_fnc_sideIsFriendly)
Not sure what the overall cost would be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes units becoming stuck in combat mode
Fixes units being triggered to enter combat/contact mode due to friendly fire
Implementation
*For a small sake of performance I'm not sorting for all friendly sides-- Instead I am focused only on units which are the same side as the shooter. Especially as it seems like allied sides trigger combat behaviour regardless.
Changes
This change will mean that units will be somewhat less immediately responsive to enemy fire -- but on the positive side, they'll actually reset when the threat is dealt with(!).
I also suspect this will fix some issues with transported troops dismounting at early times from transport vehicles. (i.e., they were sharing information with their drivers-- which triggered combat mode-- which triggered the driver to give the transported units combat mode-- which triggered them jumping out...
Yeah.