Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix params type for the position argument in taskPatrol #320

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

Keithenneu
Copy link
Contributor

When merged this pull request will:

  1. Fix the params type for the position argument in taskPatrol. It now uses the same type (any) as taskGarrison

The limited type would show script errors when using objects or groups, and then default to the group position. Which probably was the desired position in most cases anyways tbf.

Copy link
Collaborator

@diwako diwako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

_pos is handled by the CBA function anyways.

@jokoho48 jokoho48 added this to the 2.5.4 milestone Jun 8, 2022
@diwako diwako merged commit 1f0db3d into nk3nny:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants