Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about how to avoid margin-related jump "bug" #216

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Add information about how to avoid margin-related jump "bug" #216

merged 1 commit into from
Mar 7, 2018

Conversation

kjetilsbl
Copy link
Contributor

Encountered the bug which causes the animation to jump because of troubles with margin calculations, and found some useful information in the README of v2:

Due to the complexity of margins and their potentially collapsible nature, ReactCollapse does not support (vertical) margins on their children. It might lead to the animation "jumping" to its correct height at the end of expanding. To avoid this, use padding instead of margin. (see #101)

Suggest bringing it back as it apparently still helps

@selbekk
Copy link

selbekk commented Mar 6, 2018

This won't be needed after #219 is merged, hopefully 😄

nkbt
nkbt approved these changes Mar 7, 2018
View reviewed changes
Copy link
Owner

@nkbt nkbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@nkbt nkbt merged commit 4f4fbce into nkbt:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkbt nkbt nkbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjetilsbl @selbekk @nkbt